verify mail adress (and avoid sending it empty)

Hi and cheers to all,

Here is another question from a bloody beginner:

I built this form and linked it to a php file I downloaded somwhere opn a dreamweaver forum, I fiddled around until I liked it and it works fine though people keep sending it without entering their mail address (probably nothing new to the veterans out there…) I have also been fiddling around at the php code trying to find the reason as it does react on invalid addresses but does still send it if its left blank… please have a look at the code below and… please help!

if(isset($_REQUEST[‘email’]) && !empty($_REQUEST[‘email’]))
{
if (empty($email) || empty($message)) {$errors[] = “Please enter your email adress!”;}

if(preg_match("/(%0A|%0D|\n+|\r+|:)/i",$_REQUEST[‘email’])){$errors[] = “Email address may not contain a new line or a colon”;}

$_REQUEST[‘email’] = trim($_REQUEST[‘email’]);

if(substr_count($_REQUEST[‘email’],"@") != 1 || stristr($_REQUEST[‘email’]," “)){$errors[] = “Email address is invalid”;}else{$exploded_email = explode(”@",$_REQUEST[‘email’]);if(empty($exploded_email[0]) || strlen($exploded_email[0]) > 64 || empty($exploded_email[1])){$errors[] = “Email address is invalid”;}else{if(substr_count($exploded_email[1],".") == 0){$errors[] = “Email address is invalid”;}else{$exploded_domain = explode(".",$exploded_email[1]);if(in_array("",$exploded_domain)){$errors[] = “Email address is invalid”;}else{foreach($exploded_domain as $value){if(strlen($value) > 63 || !preg_match(’/^[a-z0-9-]+$/i’,$value)){$errors[] = “Email address is invalid”; break;}}}}}}

}

Big thanks!

Hi there,

Your best bet is probably a regular expression - try something like this:
[php]
if (!preg_match("/^([a-zA-Z0-9])[email protected]([a-zA-Z0-9_-])+(.[a-zA-Z0-9_-]+)+/", $_REQUEST[‘email’]))
{
$errors[] = “Invalid e-mail address”;
}
[/php]

Let me know how you get on!

Hi Smokey PHP,

Many thank but I am sorry to say it didn’t work out… it will still send blank, strangely before it would refuse to send a completely blank form but now it does, I will post the entire php script so maybe it will be easier to find out why… I have also had some issues on Google Chrome, the cursor will always jump into the previous text field when clicked, the only way to navigate it with the tab key… is the problem in the HTML or PHP?

[php]<?php

$my_email = "[email protected]";

$continue = “thankyou.html”;

$errors = array();

// Remove $_COOKIE elements from $_REQUEST.

if(count($_COOKIE)){foreach(array_keys($_COOKIE) as $value){unset($_REQUEST[$value]);}}

// Check all fields for an email header.

function recursive_array_check_header($element_value)
{

global $set;

if(!is_array($element_value)){if(preg_match("/(%0A|%0D|\n+|\r+)(content-type:|to:|cc:|bcc:)/i",$element_value)){$set = 1;}}
else
{

foreach($element_value as $value){if($set){break;} recursive_array_check_header($value);}

}

}

recursive_array_check_header($_REQUEST);

if($set){$errors[] = “You cannot send an email header”;}

unset($set);

// Validate email field.

if(isset($REQUEST[‘email’]) && !empty($REQUEST[‘email’]))
{
if (!preg_match("/^([a-zA-Z0-9])[email protected]([a-zA-Z0-9
-])+(.[a-zA-Z0-9
-]+)+/", $_REQUEST[‘email’]))
{
$errors[] = “Invalid e-mail address”;
}

if(substr_count($_REQUEST[‘email’],"@") != 1 || stristr($_REQUEST[‘email’]," “)){$errors[] = “Email address is invalid”;}else{$exploded_email = explode(”@",$_REQUEST[‘email’]);if(empty($exploded_email[0]) || strlen($exploded_email[0]) > 64 || empty($exploded_email[1])){$errors[] = “Email address is invalid”;}else{if(substr_count($exploded_email[1],".") == 0){$errors[] = “Email address is invalid”;}else{$exploded_domain = explode(".",$exploded_email[1]);if(in_array("",$exploded_domain)){$errors[] = “Email address is invalid”;}else{foreach($exploded_domain as $value){if(strlen($value) > 63 || !preg_match(’/^[a-z0-9-]+$/i’,$value)){$errors[] = “Email address is invalid”; break;}}}}}}

}

// Check referrer is from same site.

if(!(isset($_SERVER[‘HTTP_REFERER’]) && !empty($_SERVER[‘HTTP_REFERER’]) && stristr($_SERVER[‘HTTP_REFERER’],$_SERVER[‘HTTP_HOST’]))){$errors[] = “You must enable referrer logging to use the form”;}

// Check for a blank form.

function recursive_array_check_blank($element_value)
{

global $set;

if(!is_array($element_value)){if(!empty($element_value)){$set = 1;}}
else
{

foreach($element_value as $value){if($set){break;} recursive_array_check_blank($value);}

}

}

recursive_array_check_blank($_REQUEST);

if(!$set){$errors[] = “You cannot send a blank form”;}

unset($set);

// Display any errors and exit if errors exist.

if(count($errors)){foreach($errors as $value){print “$value
”;} exit;}

if(!defined(“PHP_EOL”)){define(“PHP_EOL”, strtoupper(substr(PHP_OS,0,3) == “WIN”) ? “\r\n” : “\n”);}

// Build message.

function build_message($request_input){if(!isset($message_output)){$message_output ="";}if(!is_array($request_input)){$message_output = $request_input;}else{foreach($request_input as $key => $value){if(!empty($value)){if(!is_numeric($key)){$message_output .= str_replace("_"," “,ucfirst($key)).”: “.build_message($value).PHP_EOL.PHP_EOL;}else{$message_output .= build_message($value).”, “;}}}}return rtrim($message_output,”, ");}

$message = build_message($_REQUEST);

$message = $message . PHP_EOL.PHP_EOL."-- “.PHP_EOL.”";

$message = stripslashes($message);

$subject = “FormToEmail Comments”;

$headers = "From: " . $_REQUEST[‘email’];

mail($my_email,$subject,$message,$headers);

?>[/php]

Sponsor our Newsletter | Privacy Policy | Terms of Service