IF statement outcomes both options.

<php?
if (htmlspecialchars($_GET[“e”] == 2)): {
echo(’

Your feedback has been sent, thank you!
’);
}
?>
<php?
if (htmlspecialchars($_GET[“e”] == 1)): {
echo(’
Please check your inputs and try again.’
’);
?>[/php]

For some reason it outputs both if statements, any ideas?
This is an extract from my contact page sub[/sub].

Thanks,
-Connor

Is this your actual code?
If it is you have the opening php tag wrong, it is <?php

The : after the ), before { doesn’t need to be there.
And i believe looking at your code, the if statements will always return true, thus the echo will be displayed.
I think you meant to put the ==1 / ==2 outside the htmlspecialchars
[php]if(htmlspecialchars($_GET[‘e’]) == 2) {
//…[/php]

Hope that helps,
Red :wink:

Now I am getting another error, no idea whats wrong now.
Same link as last time.
[php]<?php
require(’…/nav.php’);
?>

Contact
    <div class="row">
        <div class="col-lg-12 text-center">
            <h1>Contact</h1>
            <p class="lead">Tell me stuff!</p>
            <ul class="list-group">
				<li class="list-group-item"><b>Utilizes:</b></li>
				<li class="list-group-item">PHP</li>
				<li class="list-group-item">Email</li>
			</ul>
        </div>
    </div>
    <!-- /.row -->
<?php if (htmlspecialchars($_GET["e"]) == 2) { echo('
Your feedback has been sent, thank you!
'); if (htmlspecialchars($_GET["e"]) == 1) { echo('
Please check your inputs and try again.
'); ?>
First Name *
Last Name *
Email *
Telephone
Comments *

Submit

[/php]

The error I am getting is
[php]Parse error: syntax error, unexpected $end in /home/u846743744/public_html/contact/index.php on line 76[/php]

Also sorry about messing up the [PHP] tags on the first post.

This section here is causing the errors because both snippets are missing the closing bracket }

Here is the fix;
[php]

<?php if (htmlspecialchars($_GET["e"]) == 2) { echo('
Your feedback has been sent, thank you!
'); } if (htmlspecialchars($_GET["e"]) == 1) { echo('
Please check your inputs and try again.
'); } ?>

[/php]

Hope that helps,
Red :wink:

It does indeed, thanks. You’ve been a great help!
+1 karma

You’re very welcome, happy to help. :wink:

D:
[php]Parse error: syntax error, unexpected $end in /home/u846743744/public_html/contact/send_form_email.php on line 166[/php]
[php]<?php
echo(“Please wait…”);
if(isset($_POST[‘email’])) {

// EDIT THE 2 LINES BELOW AS REQUIRED

$email_to = "[email protected]";

$email_subject = ($_POST['first_name']) . " " . ($_POST['last_name']) . " - Connor's Stuff: Feedback";

 

 

function died($error) {

    // your error code can go here
    header('Location: ../contact?e=1&v=' . $error_message);

    echo "If you are seeing this connor *OMITTED*ed up.";

    die();

}

function diedcap() {
  header('Location: ../contact?e=3');
}

function yay() {
	header('Location: ../contact?e=2');

}

 

// validation expected data exists

if(!isset($_POST['first_name']) ||

    !isset($_POST['last_name']) ||

    !isset($_POST['email']) ||

    !isset($_POST['telephone']) ||

    !isset($_POST['comments'])) {

    died('We are sorry, but there appears to be a problem with the form you submitted.');       

}

 

$first_name = $_POST['first_name']; // required

$last_name = $_POST['last_name']; // required

$email_from = $_POST['email']; // required

$telephone = $_POST['telephone']; // not required

$comments = $_POST['comments']; // required

 

$error_message = "";

$email_exp = '/^[A-Za-z0-9._%-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,4}$/';

if(!preg_match($email_exp,$email_from)) {

$error_message .= 'The email you entered does not appear to be valid.<br />';

}

$string_exp = "/^[A-Za-z .'-]+$/";

if(!preg_match($string_exp,$first_name)) {

$error_message .= 'The first name you entered does not appear to be valid.<br />';

}

if(!preg_match($string_exp,$last_name)) {

$error_message .= 'The last name you entered does not appear to be valid.<br />';

}

if(strlen($comments) < 2) {

$error_message .= 'The comment you entered does not appear to be valid.<br />';

}

if(strlen($error_message) > 0) {

died();

}

if(isset($_POST[‘g-recaptcha-response’])){
$captcha=$_POST[‘g-recaptcha-response’];
}
if(!$captcha){
diedcap();
}
$response=file_get_contents(“https://www.google.com/recaptcha/api/siteverify?secret=XXXXXXXXXXXXXXXXXXXXXXX&response=".$captcha."&remoteip=”.$_SERVER[‘REMOTE_ADDR’]);
if($response.success==false)
{
diedcap();

$email_message = "Form details below.\n\n";

 

function clean_string($string) {

  $bad = array("content-type","bcc:","to:","cc:","href");

  return str_replace($bad,"",$string);

}

 

$email_message .= "First Name: ".clean_string($first_name)."\n";

$email_message .= "Last Name: ".clean_string($last_name)."\n";

$email_message .= "Email: ".clean_string($email_from)."\n";

$email_message .= "Telephone: ".clean_string($telephone)."\n";

$email_message .= "Comments: ".clean_string($comments)."\n";

}

// create email headers

$headers = 'From: '.$email_from."\r\n".

'Reply-To: '.$email_from."\r\n" .

‘X-Mailer: PHP/’ . phpversion();

@mail($email_to, $email_subject, $email_message, $headers);

yay();
?>

Thank you for contacting us. We will be in touch with you very soon.

[/php]

Different error, same cause, missing final closing bracket }

Do you use an IDE to code in?
The reason i ask is i pasted your code into my editor and it was immediately apparent the last bracket was missing.

One other thing, this line here:
[php]@mail($email_to, $email_subject, $email_message, $headers);[/php]
Don’t use the @ symbol in your code, it is an error suppressor.

Top Tip: When your code throws up an error, It is telling you something needs your attention.
Learn to fix it, don’t hide it.

Red :wink:

Agreed. It is rare that you will need to suppress an error, and when you do need to you should be at a point in which you understand why.

Sublime Text, did I just miss it or does it not point it out.
What do you use?

I use Eclipse.

Sponsor our Newsletter | Privacy Policy | Terms of Service