Help with INSERT INTO Mysql Database

[system]

Hi, I’m new to PhP & MySQL and I’m trying to insert records from a form for new members of a tennis club into a MySQL database. I seem to be having some trouble. I created the form (new_user_form.php) already. I’m a beginner and I know how cocky some people may be towards me upon looking at my code. So please, only cordially helpful suggestions, ad ridiculaous at this may look! Here’s the code for the insert handler (new_user_insert.php):

[php]<?php

$host = “localhost:8889”
$username = “root”
$password0 = “password”
$db_name = “members”
$tblname = “new_users”

mysql_connect($host, $username, $password0) or die(cannot connect!)
mysql_select_db("$db_name") or die(“cannot select table!”).

$username=$_POST[‘uname’];
$password1=$_POST[‘password1’];
$f_name=$_POST[‘fname’];
$f_name=$_POST[‘lname’];
$f_name=$_POST[‘pname’];
$email=$_POST[‘email’];
$gender=$_POST[‘gender’];
$age=$_POST[‘age’];
$ntrp_level=$_POST[‘ntrplevel’];
$courtuse1=$_POST[‘courtuse1’];
$courtuse2=$_POST[‘courtuse2’];
$courtuse3=$_POST[‘courtuse3’];
$courtuse4=$_POST[‘courtuse4’];
$courtuse5=$_POST[‘courtuse5’];
$courtuse6=$_POST[‘courtuse6’];
$courtuse7=$_POST[‘courtuse7’];
$courtuse8=$_POST[‘courtuse8’];
$courtuse9=$_POST[‘courtuse9’];
$surface1=$_POST[‘surface1’];
$surface2=$_POST[‘surface2’];
$surface3=$_POST[‘surface3’];
$surface4=$_POST[‘surface4’];
$dexterity=$_POST[‘dexterity’];

$sql = "INSERT INTO $tbl_name(
username,
password1,
f_name,
l_name,
p_name,
email,
gender,
age,
ntrp_level,
courtuse1,
courtuse2,
courtuse3,
courtuse4,
courtuse5,
courtuse6,
courtuse7,
courtuse8,
courtuse9,
surface1,
surface2,
surface3,
surface4,
dexterity
)

VALUES(
‘$username’;
‘$password1’;
‘$f_name’,
‘$f_name’,
‘$f_name’,
‘$email’,
‘$gender’,
‘$age’,
‘$ntrp_level’,
‘$courtuse1’,
‘$courtuse2’,
‘$courtuse3’,
‘$courtuse4’,
‘$courtuse5’,
‘$courtuse6’,
‘$courtuse7’,
‘$courtuse8’,
‘$courtuse9’,
‘$surface1’,
‘$surface2’,
‘$surface3’,
‘$surface4’
)";

$result=mysql_query($sql);

if($result){
echo “Success!”;
echo “
”;
echo “Back to main page”;
}
else{
echo “ERROR!”;
}
?>

<?php mysql_close(); ?>

[/php]

[Strider64]

My first suggestion is either use mysqli or PDO for mysql is DEPRECIATED. http://us2.php.net/manual/en/mysqli.query.php or http://us2.php.net/manual/en/pdo.prepare.php

Secondly I think you can fine tune your user inputs to a more sizable manner? No biggie if you can’t

And lastly when you having it work I would suggest:

[php]<?php
// Clunky and not very html/css friendly
if ($result) {
echo “Success!”;
echo “
”;
echo “Back to main page”;
} else {
echo “ERROR!”;
}

if ($result) { // Nicer and if you have it working a user will know:
$_SESSION[‘successMsg’] = ‘Success!!!’; // I suggest reading up on $_SESSION @ php.net:
header(‘Location: new_user_form.php’);
exit();
}
[/php]

[ham9285]

Thanks!