Fixing website Admin forms

General PHP Help
#1

I have to fix my company’s website since the web guy quit. I’m a machinist and barely know some python/c++. I don’t really know php.
Quick rundown:
There is an admin page to create entries in Shows and Articles.
Articles pages works correctly.
Shows page is virtually identical in code (fields are different), but will not update.
The if/elseif/else works correctly taking me back to where I need to be after hitting the ‘Submit’ button, but the list is not updated.

in the editArticle.php
[php]<?php if ( $results['article']->id ) { ?>


<input type=“button” class=“btn” title=“Delete article” id=“delete” value=“Delete Article” onclick=“location.href=‘articles.php?action=delete&id=<?= $results["article"]->id ?>’; return confirm(‘Delete This Article?’)” >
<?php } else { ?>


<?php } ?>[/php]

in articles.php
[php]function newArticle() {

$results = array();
$results[‘pageTitle’] = “New Article”;
$results[‘formAction’] = “new”;

if ( isset( $_POST[‘saveChanges’] ) ) {

// User has posted the article edit form: save the new article
$article = new Article;
$article->storeFormValues( $_POST );
$article->insert();
header( "Location: articles.php?action=articles&amp;status=changesSaved" );

} elseif ( isset( $_POST[‘cancel’] ) ) {

// User has cancelled their edits: return to the article list
header( "Location: articles.php" );

} else {

// User has not posted the article edit form yet: display the form
$results['article'] = new Article;
require( TEMPLATE_PATH . "/articles/editArticle.php" );

}

}[/php]

editShows.php
[php]<?php if ( $results['show']->id ) { ?>


<input type=“button” class=“button” title=“Delete Show” id=“delete” value=“Delete Show” onclick=“location.href=‘shows.php?action=delete&id=<?= $results["show"]->id ?>’; return confirm(‘Delete This Show?’)” >
<?php } else { ?>


<?php } ?>[/php]

Shows.php
[php]function newShow() {

$results = array();
$results[‘pageTitle’] = “New Show”;
$results[‘formAction’] = “new”;

if ( isset( $_POST[‘addNew’] ) ) {

// User has posted the shows edit form: save the new show
$show = new Show;
$show->storeFormValues( $_POST );
$show->insert();
header( "Location: shows.php?action=shows&amp;status=changesSaved" );

} elseif ( isset( $_POST[‘cancel’] ) ) {

// User has cancelled their edits: return to the shows list
header( "Location: shows.php" );

} else {

// User has not posted the show edit form yet: display the form
$results['show'] = new Show;
require( TEMPLATE_PATH . "/shows/editShow.php" );

}

}[/php]

Am I looking in the wrong area? Will attach all files if necessary, they aren’t too big. Please help me, I’m going crazy. Thank you.

#2

You should probably be looking for a function called “editShow”, after that, the database interaction looks to be in a class called “Show”. There is most likely going to be a method (function) inside that class called “update”.

If that isn’t the case, and the editing is being handled by the newShow function (bad coding practices, as functions should do what they say they are doing), you are probably looking at changing a few words. We will await your reply, before diving into that one. Posting the contents of the class “Show” method (function) “insert” would also go along way on solving your current situation.

This is all based off of the naming conventions of the scripts you have provided. Good Hunting.

#3

here is shows.php
[php]<?php

require( “config.php” );

$action = isset( $_GET[‘action’] ) ? $_GET[‘action’] : “”;
if (!isset( $_SESSION[‘username’] ))
header(‘Location: index.php’);

switch ( $action ) {
case ‘shows’:
listShows();
break;
case ‘new’:
newShow();
break;
case ‘edit’:
editShow();
break;
case ‘delete’:
deleteShow();
break;
default:
listShows();
}

/PRODUCTS/
function listShows() {
$results = array();
$data = Show::getList();
$results[‘shows’] = $data[‘results’];
$results[‘totalRows’] = $data[‘totalRows’];
$results[‘pageTitle’] = “All Shows”;

if ( isset( $_GET[‘error’] ) ) {
if ( $_GET[‘error’] == “showNotFound” ) $results[‘errorMessage’] = “Error: Show not found.”;
}

if ( isset( $_GET[‘status’] ) ) {
if ( $_GET[‘status’] == “changesSaved” ) $results[‘statusMessage’] = “Your changes have been saved.”;
if ( $_GET[‘status’] == “showDeleted” ) $results[‘statusMessage’] = “Show deleted.”;
}

require( TEMPLATE_PATH . “/shows/listShows.php” );
}

function newShow() {

$results = array();
$results[‘pageTitle’] = “New Show”;
$results[‘formAction’] = “new”;

if ( isset( $_POST[‘addNew’] ) ) {

// User has posted the shows edit form: save the new show
$show = new Show;
$show->storeFormValues( $_POST );
$show->insert();
header( "Location: shows.php?action=shows&amp;status=changesSaved" );

} elseif ( isset( $_POST[‘cancel’] ) ) {

// User has cancelled their edits: return to the shows list
header( "Location: shows.php" );

} else {

// User has not posted the show edit form yet: display the form
$results['show'] = new Show;
require( TEMPLATE_PATH . "/shows/editShow.php" );

}

}

function editShow() {

$results = array();
$results[‘pageTitle’] = “Edit Show”;
$results[‘formAction’] = “edit”;

if ( isset( $_POST[‘saveChanges’] ) ) {

// User has posted the show edit form: save the show changes

if ( !$show = Show::getById( (int)$_POST['id'] ) ) {
  header( "Location: shows.php?action=shows&amp;error=showNotFound" );
  return;
}

$show->storeFormValues( $_POST );
$show->update();
header( "Location: shows.php?action=shows&amp;status=changesSaved" );

} elseif ( isset( $_POST[‘cancel’] ) ) {

// User has cancelled their edits: return to the show list
header( "Location: shows.php" );

} else {

// User has not posted the show edit form yet: display the form
$results['show'] = Show::getById( (int)$_GET['id'] );
require( TEMPLATE_PATH . "/shows/editShow.php" );

}

}

function deleteShow() {

if ( !$show = Show::getById( (int)$_GET[‘id’] ) ) {
header( “Location: shows.php?action=shows&error=showNotFound” );
return;
}

$show->delete();
header( “Location: shows.php?action=shows&status=showDeleted” );
}
?>
[/php]

and editShows.php[php]

<?php include "templates/include/head.php" ?>
<?php include "templates/include/footer.php" ?>

[/php]

It does have the editShow with update(). I can successfully edit an entry. I’ve been at this for about 8 hrs total now and want to smash this computer.

Just in case it’s here - listShows.php[php]

<?php include "templates/include/head.php" ?>
<?php include "templates/include/header.php" ?> 
<tr>
  <td class="clickable new" colspan="4" onclick="location='shows.php?action=new'">
    Add new show
  </td>
</tr>
<?php foreach ( $results['shows'] as $show ) { ?> 
<tr>
  <td class="clickable edit" onclick="location='shows.php?action=edit&amp;id=<?= $show->id?>'" title="Edit Show">
    <?= $show->title?>
  </td>
  <td>
    <?= gmdate('M j', $show->startDate).' - '.gmdate('j, Y', $show->endDate)?>
  </td>
  <td>
    <?= $show->locality?>
  </td>
  <td class="clickable delete" onclick="location.href='shows.php?action=delete&amp;id=<?= $show->id ?>'; return confirm('Delete This Show?')" title="Delete Show">
    <?= $show->administrative_area_level_1?>
  </td>
</tr>

<?php } ?>

<tr>
  <td class="clickable new" colspan="4" onclick="location='shows.php?action=new'">
    Add new show
  </td>
</tr>
Title Date City State

<?= $results['totalRows']?> show<?= ( $results['totalRows'] != 1 ) ? 's' : '' ?> in total.

<?php include "templates/include/footer.php" ?>[/php]
#4

I’m slightly confused, in the OP you stated:

Shows page is virtually identical in code (fields are different), [b]but will not update.[/b] The if/elseif/else works correctly taking me back to where I need to be after hitting the 'Submit' button, but the list is not updated.

Then you stated in your second post:

[b] I can successfully edit an entry[/b]. I've been at this for about 8 hrs total now and want to smash this computer.

So, I’m not real sure where you are stuck, I thought you couldn’t edit the entry. So, we need to back up a little bit.

What exactly is the issue. Cannot add new show? You need to check the SQL query in the Show::insert() method to make sure it is built correctly. You can echo that to the page and then copy/paste it into the database console, or exit() (php function) on error, trigger_error() (php function) to capture the error in your error log (depends on php settings). This will tell you if the query is failing. There should already be check in place for that, but some coders are lazy (most are at some point in time, me included).

You can trace updates with the same strategy, only looking at the method Show::update().

#5

I don’t know how to do any of that. But, there is some try and catch stuff. No errors on error.log.
I’m looking at the class files now, but as I stated in OP, this is beyond me. We can just shut this one down, I don’t think it’ll get resolved.

Sponsor our Newsletter | Privacy Policy | Terms of Service