File upload

dukes · February 9, 2013, 12:10am

Okay so I have a little image file upload script… And say for example; test.png has already been uploaded, and say someone else uploads a file called test.png, it’ll rename it to like test9234743.png, and it’ll take them to test.png, how come it wont take them to test9234743.png?

My code:

[code]<?php
$allowedExts = array(“jpg”, “jpeg”, “gif”, “png”, “PNG”, “JPG”, “JPEG”, “GIF”);
$extension = end(explode(".", $_FILES[“file”][“name”]));
if ((($_FILES[“file”][“type”] == “image/gif”)
|| ($_FILES[“file”][“type”] == “image/jpeg”)
|| ($_FILES[“file”][“type”] == “image/png”)
|| ($_FILES[“file”][“type”] == “image/pjpeg”))
&& ($_FILES[“file”][“size”] < 5302067 )
&& in_array($extension, $allowedExts))
{
if ($_FILES[“file”][“error”] > 0)
{
echo "Return Code: " . $_FILES[“file”][“error”] . “
”;
}
else
{
echo header(“Location: http://www.dukaj.com/gallery/” . $_FILES[“file”][“name”]);

if (file_exists("gallery/" . $_FILES["file"]["name"]))
  {
     $index = strpos($_FILES["file"]["name"], '.', -1);
     $_FILES["file"]["name"] = (substr($_FILES["file"]["name"], 0, $index) . rand(0, 999999999) . substr($_FILES["file"]["name"], $index + 1)); // COELHO

// echo $_FILES[“file”][“name”] . " already exists. Rename your file. "; COELHO
}
// else COELHO
// { COELHO
move_uploaded_file($_FILES[“file”][“tmp_name”],
“gallery/” . $_FILES[“file”][“name”]);
//echo "Stored in: " . “gallery/” . $_FILES[“file”][“name”];

// } COELHO
}
}
else
{
echo “Invalid upload. We only allow png, jpg, and gif images.”;
}
?>[/code]

Any help is greatly accepted!

m11 · February 9, 2013, 12:39am

You are redirecting before even checking if the file exists. The header should be last (and also remove echo)

[php]
$allowedExts = array(“jpg”, “jpeg”, “gif”, “png”, “PNG”, “JPG”, “JPEG”, “GIF”);
$extension = end(explode(".", $_FILES[“file”][“name”]));

if ((($_FILES[“file”][“type”] == “image/gif”)
|| ($_FILES[“file”][“type”] == “image/jpeg”)
|| ($_FILES[“file”][“type”] == “image/png”)
|| ($_FILES[“file”][“type”] == “image/pjpeg”))
&& ($_FILES[“file”][“size”] < 5302067 )
&& in_array($extension, $allowedExts)) {

if ($_FILES["file"]["error"] > 0) {
	echo "Return Code: " . $_FILES["file"]["error"] . "<br>";
}
else {
	if (file_exists("gallery/" . $_FILES["file"]["name"])) {
		$index = strpos($_FILES["file"]["name"], '.', -1);
		$_FILES["file"]["name"] = (substr($_FILES["file"]["name"], 0, $index) . rand(0, 999999999) . substr($_FILES["file"]["name"], $index + 1)); // COELHO
	}
	move_uploaded_file($_FILES["file"]["tmp_name"], "gallery/" . $_FILES["file"]["name"]);
	header("Location: http://www.dukaj.com/gallery/" . $_FILES["file"]["name"]);
}

}
else {
echo “Invalid upload. We only allow png, jpg, and gif images.”;
}
[/php]

dukes · February 9, 2013, 12:45am

$allowedExts = array(“jpg”, “jpeg”, “gif”, “png”, “PNG”, “JPG”, “JPEG”, “GIF”); $extension = end(explode(".", $_FILES[“file”][“name”])); if ((($_FILES[“file”][“type”] == “image/gif”) || ($_FILES[“file”][“type”] == “image/jpeg”) || ($_FILES[“file”][“type”] == “image/png”) || ($_FILES[“file”][“type”] == “image/pjpeg”)) && ($_FILES[“file”][“size”] < 5302067 ) && in_array($extension, $allowedExts)) { if ($_FILES[“file”][“error”] > 0) { echo "Return Code: " . $_FILES[“file”][“error”] . "
"; } else { if (file_exists(“gallery/” . $_FILES[“file”][“name”])) { $index = strpos($_FILES[“file”][“name”], ‘.’, -1); $_FILES[“file”][“name”] = (substr($_FILES[“file”][“name”], 0, $index) . rand(0, 999999999) . substr($_FILES[“file”][“name”], $index + 1)); // COELHO } move_uploaded_file($_FILES[“file”][“tmp_name”], “gallery/” . $_FILES[“file”][“name”]); header(“Location: http://www.dukaj.com/gallery/” . $_FILES[“file”][“name”]); } } else { echo “Invalid upload. We only allow png, jpg, and gif images.”; }